Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary-compatibility-validator #244

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add binary-compatibility-validator #244

merged 1 commit into from
Mar 2, 2024

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Jun 6, 2023

  • save current api dump
  • add running build on CI

Motivation:

Upcoming PRs with new transport API will start breaking API a little, so let's try already to keep it under control

@whyoleg
add BCV
149f498 
* save current api dump
* add running build on CI
@whyoleg whyoleg added the task label Jun 6, 2023
@whyoleg whyoleg self-assigned this Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

   699 files  ±0     699 suites  ±0   27m 30s ⏱️ + 1m 37s
2 179 tests ±0  1 958 ✔️  - 1  220 💤 ±0  1 ❌ +1 
4 562 runs  ±0  4 049 ✔️  - 1  512 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 149f498. ± Comparison against base commit 88e6928.

This pull request removes 201 and adds 201 tests. Note that renamed tests count towards both. 
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
…

io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
…
This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both. 
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless113.0.5672.63, Linuxx86_64]

io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless113.0.5672.126, Linuxx86_64]

@whyoleg whyoleg requested review from OlegDokuka and removed request for OlegDokuka February 27, 2024 21:15
This was referenced Feb 28, 2024
Merged
Merged
Merged
@whyoleg whyoleg merged commit e5e292b into master Mar 2, 2024
@whyoleg whyoleg deleted the bcv branch March 2, 2024 08:11
@whyoleg whyoleg mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

@yschimke yschimke Awaiting requested review from yschimke

Assignees

@whyoleg whyoleg

Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyoleg @OlegDokuka