Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce new module rsocket-internal-io #247

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Jun 6, 2023

Motivation:

New module is a support module for core and transport implementations.
This allows to drop using internal declarations, as well as not exposing it to library consumers, until explicitly requested

Depends on: #244

@whyoleg whyoleg self-assigned this Jun 6, 2023
@whyoleg whyoleg added task and removed enhancement labels Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

   699 files  ±0     699 suites  ±0   27m 3s ⏱️ -27s
2 179 tests ±0  1 957 ✔️  - 1  220 💤 ±0  2 +1 
4 562 runs  ±0  4 048 ✔️  - 1  512 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 37315f8. ± Comparison against base commit 149f498.

♻️ This comment has been updated with latest results.

Base automatically changed from bcv to master March 2, 2024 08:11
…for core and transport implementations

This allows to drop using internal declarations, as well as not exposing it to library consumers, until explicitly requested
@whyoleg whyoleg merged commit 45f7158 into master Mar 2, 2024
0 of 22 checks passed
@whyoleg whyoleg deleted the extract-internal-io branch March 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants