This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Hating on HTML fixtures #1306
Merged
Hating on HTML fixtures #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means less churn in diffs. We weren't asserting on these lines anyway.
This still gives us a high level of confidence in the HTML formatter, while drastically reducing the complexity of the specs. We only require a single fixture with this method.
|
Seems legit to me, although you're right the fixture script won't work at all for me ;) |
|
I was torn ... everyone is going to have a different script, but it seems better to have something here rather than nothing? Though if we merge this basically as is the need for it pretty much goes away. |
This was referenced Feb 9, 2014
|
This has never been a pain point for me, but these are definite improvements, so LGTM. Merge away. |
|
I currently can't compile 1.9.2 so can't get any of my PRs green. Too much yak shaving for a Sunday. This will be a big help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML fixtures churn a lot, are a PITA to re-generate, and don't provide a lot of value. Here is an alternate suggestion:
@myronmarston @JonRowe @soulcutter @samphippen