This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Only verify HTML fixtures on modern rubies. #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still gives us a high level of confidence in the HTML formatter, while drastically reducing the complexity of the specs. We only require a single fixture with this method. I removed some of the textmate coverage, since it was incompatible with this change and it's going away anyway so I don't care about it. Backport from RSpec 3.
|
👍 |
xaviershay
added a commit
that referenced
this pull request
Feb 9, 2014
Only verify HTML fixtures on modern rubies.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…backport Only verify HTML fixtures on modern rubies. --- This commit was imported from rspec/rspec-core@baa3474.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still gives us a high level of confidence in the HTML formatter,
while drastically reducing the complexity of the specs. We only require
a single fixture with this method.
I removed some of the textmate coverage, since it was incompatible with
this change and it's going away anyway so I don't care about it.
Backport of #1306, I'm going to merge when green.