Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ruby < 2.3 support #2787

Merged
merged 19 commits into from
Dec 14, 2020
Merged

Drop Ruby < 2.3 support #2787

merged 19 commits into from
Dec 14, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Nov 23, 2020 •
edited
Loading

Better viewed as https://github.com/rspec/rspec-core/pull/2787/files?diff=split&w=1

Sibling PRs:

TODO (not all):

  • def self.ensure_example_groups_are_configured
  • For some reason JRuby doesn't like our improved bundler setup
  • echo "WARNING: Cucumber is skipped on JRuby on rspec-core due to" \
  • lib/rspec/core/test_unit_assertions_adapter.rb
  • [#] Mini[t|T]est - always Minitest
  • ...

@pirj pirj self-assigned this Nov 23, 2020
@pirj pirj force-pushed the drop-old-rubies branch 5 times, most recently from 62b77ba to 0373f4c Compare November 26, 2020 21:10
@pirj pirj changed the title [Don't review just yet, plenty of TODOs all around] Drop Ruby < 2.3 support [Don't review just yet] Drop Ruby < 2.3 support Nov 26, 2020
@pirj pirj force-pushed the drop-old-rubies branch 6 times, most recently from 7a6f68f to f3b9634 Compare November 27, 2020 20:00
pirj
pirj commented Nov 27, 2020
View reviewed changes
lib/rspec/core/example_group.rb Outdated Show resolved Hide resolved
pirj added a commit to rspec/rspec-mocks that referenced this pull request Nov 27, 2020
@pirj
Prefer alias_method inside DSL
d1258c4 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
This was referenced Nov 29, 2020
Merged
Merged
Merged
Closed
Closed
@pirj pirj force-pushed the 4-0-dev branch 2 times, most recently from 119e334 to d11d9b9 Compare December 6, 2020 22:06
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 8, 2020
@pirj
Prefer alias_method inside DSL
d573e32 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 8, 2020
@pirj
Prefer alias_method inside DSL
3428f61 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
@pirj pirj force-pushed the drop-old-rubies branch 2 times, most recently from 41d9758 to cbdf1c7 Compare December 8, 2020 21:34
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 8, 2020
@pirj
Prefer alias_method inside DSL
32e81ca 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
@pirj pirj changed the title [Don't review just yet] Drop Ruby < 2.3 support Drop Ruby < 2.3 support Dec 8, 2020
@pirj
Copy link
Member Author

pirj commented Dec 13, 2020

Updates:

  • reverted changes to gemspec
  • accepted proposed changes
  • added (a reduced version of) comment to Mini[t|T]est adapter

@pirj pirj requested a review from JonRowe December 13, 2020 16:06
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 13, 2020
@pirj
Prefer alias_method inside DSL
bb1489b 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
JonRowe
JonRowe reviewed Dec 13, 2020
View reviewed changes
lib/rspec/core.rb Outdated Show resolved Hide resolved
@pirj pirj requested a review from JonRowe December 13, 2020 21:29
@pirj
Copy link
Member Author

pirj commented Dec 13, 2020

There's definitely something wrong with rubocop.
It should fail, but sometimes it does and sometimes not.
I'll figure it out later. Meanwhile reverted.

@JonRowe JonRowe merged commit 7329163 into 4-0-dev Dec 14, 2020
@JonRowe JonRowe deleted the drop-old-rubies branch December 14, 2020 08:56
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 14, 2020
@pirj
Prefer alias_method inside DSL
8c56a06 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
pirj added a commit to rspec/rspec-mocks that referenced this pull request Dec 14, 2020
@pirj
Prefer alias_method inside DSL
d968590 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)
@pirj pirj restored the drop-old-rubies branch December 14, 2020 17:14
@pirj
Copy link
Member Author

pirj commented Dec 14, 2020

Restored the branch, rspec-support depends on it.

@pirj pirj deleted the drop-old-rubies branch December 15, 2020 08:36
@pirj pirj mentioned this pull request Dec 15, 2020
Open
53 tasks
@pirj pirj added this to the 4.0 milestone Dec 25, 2020
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
@JonRowe
[core] Merge pull request rspec/rspec-core#2787 from rspec/drop-old-r…
332d1c1 
…ubies

Drop Ruby < 2.3 support

---
This commit was imported from rspec/rspec-core@7329163.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
@pirj
[mocks] Prefer alias_method inside DSL
cc7860d 
See:
  https://rubystyle.guide/#alias-method
  rspec/rspec-core#2787 (comment)

---
This commit was imported from rspec/rspec-mocks@d968590.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt Awaiting requested review from benoittgt

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pirj @JonRowe