-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Ruby < 2.3 support #2787
Merged
Merged
Drop Ruby < 2.3 support #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
drop-old-rubies
branch
5 times, most recently
from
November 26, 2020 21:10
62b77ba
to
0373f4c
Compare
pirj
changed the title
[Don't review just yet, plenty of TODOs all around] Drop Ruby < 2.3 support
[Don't review just yet] Drop Ruby < 2.3 support
Nov 26, 2020
pirj
force-pushed
the
drop-old-rubies
branch
6 times, most recently
from
November 27, 2020 20:00
7a6f68f
to
f3b9634
Compare
pirj
commented
Nov 27, 2020
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Nov 27, 2020
pirj
force-pushed
the
drop-old-rubies
branch
from
November 28, 2020 19:18
47d7fab
to
1fbce7b
Compare
This was referenced Nov 29, 2020
pirj
force-pushed
the
4-0-dev
branch
2 times, most recently
from
December 6, 2020 22:06
119e334
to
d11d9b9
Compare
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 8, 2020
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 8, 2020
pirj
force-pushed
the
drop-old-rubies
branch
2 times, most recently
from
December 8, 2020 21:34
41d9758
to
cbdf1c7
Compare
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 8, 2020
pirj
changed the title
[Don't review just yet] Drop Ruby < 2.3 support
Drop Ruby < 2.3 support
Dec 8, 2020
pirj
force-pushed
the
drop-old-rubies
branch
from
December 13, 2020 15:51
2a6bd91
to
b477a27
Compare
Updates:
|
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 13, 2020
JonRowe
reviewed
Dec 13, 2020
pirj
force-pushed
the
drop-old-rubies
branch
from
December 13, 2020 21:18
50a7b80
to
f41dc2f
Compare
There's definitely something wrong with rubocop. |
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 14, 2020
pirj
added a commit
to rspec/rspec-mocks
that referenced
this pull request
Dec 14, 2020
Restored the branch, |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…ubies Drop Ruby < 2.3 support --- This commit was imported from rspec/rspec-core@7329163.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
See: https://rubystyle.guide/#alias-method rspec/rspec-core#2787 (comment) --- This commit was imported from rspec/rspec-mocks@d968590.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better viewed as https://github.com/rspec/rspec-core/pull/2787/files?diff=split&w=1
Sibling PRs:
TODO (not all):