This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoittgt
reviewed
Nov 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouhaoo. So happy with those changes. I have few questions.
pirj
force-pushed
the
drop-old-rubies
branch
from
November 15, 2020 17:01
d5dfbd2
to
7045e59
Compare
JonRowe
reviewed
Nov 15, 2020
pirj
force-pushed
the
drop-old-rubies
branch
7 times, most recently
from
November 15, 2020 23:51
5a84331
to
7e76f8e
Compare
pirj
force-pushed
the
drop-old-rubies
branch
4 times, most recently
from
November 18, 2020 15:22
2212a26
to
90a7f02
Compare
pirj
changed the title
Drop Ruby < 2.3
[Quite far from being ready, please don't review just yet] Drop Ruby < 2.3
Nov 21, 2020
pirj
force-pushed
the
drop-old-rubies
branch
2 times, most recently
from
November 22, 2020 21:43
1c13c7b
to
32d7094
Compare
pirj
changed the title
[Quite far from being ready, please don't review just yet] Drop Ruby < 2.3
[Please don't review just yet] Drop Ruby < 2.3
Nov 23, 2020
This was referenced Nov 29, 2020
pirj
commented
Dec 8, 2020
This comment has been minimized.
This comment has been minimized.
pirj
force-pushed
the
drop-old-rubies
branch
from
December 14, 2020 16:28
47d2e5e
to
4d974bc
Compare
Update: reverted the removal of |
I'm combining ReentrantMutex and Mutex in
|
lib/rspec/mocks/order_group.rb 90.48 %
pirj
force-pushed
the
drop-old-rubies
branch
from
December 14, 2020 17:11
4d974bc
to
d02dd01
Compare
JonRowe
reviewed
Dec 14, 2020
Co-authored-by: Jon Rowe <hello@jonrowe.co.uk>
JonRowe
approved these changes
Dec 15, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…-rubies Drop Ruby < 2.3 support --- This commit was imported from rspec/rspec-mocks@9fbf115.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better viewed ignoring indentation changes https://github.com/rspec/rspec-mocks/pull/1349/files?diff=split&w=1
Sibling PRs:
As per rspec/rspec#61 (comment)
config.extend RSpec::Support::RubyFeatures
config.include RSpec::Support::RubyFeatures
method_missing
is defined but should not jruby/jruby#1398 - only fixed in JRuby 9.2