Fix uninitialized constant RSpec::Rails::OpenStruct error #2754
Conversation
This started to occur on recent test suite runs. It may be related to a json gem update that removed the ostruct dependency as I encountered this with turbo_tests and a fix for that is in serpapi/turbo_tests#49 with more details.
|
Thank you! |
|
@pirj thank you for the quick turnaround! I'll go back to update the other PR and see what errors remain. |
|
@pirj this needs to be reverted or the require moved to a sub process... it could cause dependency based issues for us / our users |
|
@JonRowe I can try to help. Why would it need to be reverted if the |
|
We could just use a Class.new to create an interface that that view helper needs. |
|
That would be ideal over using OpenStruct since it's been a long time now that Ruby has advised to not use it. I'm not familiar with the requirements for this project so likely missing something. Can I help with a PR to do that instead? |
| @@ -187,7 +188,7 @@ def _default_file_to_render; end # Stub method | |||
| Class.new do | |||
| include ViewExampleGroup::ExampleMethods | |||
| def controller | |||
| @controller ||= OpenStruct.new(params: nil) | |||
| @controller ||= ::OpenStruct.new(params: nil) | |||
There was a problem hiding this comment.
I think this can become just Struct.new(:params).new(nil), and we’re openstruct-free with no side effects.
There was a problem hiding this comment.
Ok I will submit a PR with that change to start the replacement.
The reason for this policy is that it means we could inadvertandly then use openstruct and cause breakages. The replacement in #2755 is much better thank you. |
|
Yes, I think it's better too to avoid OpenStruct if possible. Thanks! |
This started to occur on recent test suite runs e.g. #2752, #2753. It may be related to a
jsongem update (example) that removed theostructdependency as I encountered that withturbo_testswhich I use to run my rspec test suite.