Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninitialized constant RSpec::Rails::OpenStruct error #2754

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix uninitialized constant RSpec::Rails::OpenStruct error #2754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/rspec/rails/example/view_example_group_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
require 'ostruct'
require 'support/group_failure_formatter'

module RSpec::Rails
Expand Down Expand Up @@ -187,7 +188,7 @@ def _default_file_to_render; end # Stub method
Class.new do
include ViewExampleGroup::ExampleMethods
def controller
@controller ||= OpenStruct.new(params: nil)
@controller ||= ::OpenStruct.new(params: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can become just Struct.new(:params).new(nil), and we’re openstruct-free with no side effects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will submit a PR with that change to start the replacement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirj I made this change in #2755

end
end.new
end
Expand Down