Fix jazzy

[Rayman]

This PR fixes the change in API for calculateMinAndMaxDistances due to the following PR: ros-navigation/navigation2#3875

This PR buils on top of the changes from: #414

[Rayman]

Can somebody look at this PR?

[Timple]

ping?

[Timple]

pinging @corot as it seems you are the last one who merged something in this repository 🙂

[corot]

pinging @corot as it seems you are the last one who merged something in this repository 🙂

I guess I'm the closest to a maintainer for this repo.... but I'm still stuck with ROS 1, so cannot test this.
I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

[Rayman]

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create the following branches:
humble-devel: contains the current ros2-master code
iron-devel: contains this PR: #414
ros2-master should contain #414 + this PR

[renan028]

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create the following branches: humble-devel: contains the current ros2-master code iron-devel: contains this PR: #414 ros2-master should contain #414 + this PR

I have created the humble branch and I will try the PR this week, and sync with @corot
Thank you for the PR

[corot]

I have created the humble branch and I will try the PR this week, and sync with @corot Thank you for the PR

thanks! what about the build farm to create the debians? I guess we need to change to use one branch or the other

also, I would not call it -devel... I expect pretty little additional development here

[renan028]

@Rayman
It looks like ros-jazzy-libg2o is not compatible with teb in this version.
g2o::sign was removed (I have checked that it exists on latest release but not in g2o master branch)
Did you manually change to use release to build it?

I have managed to build with this PR: #425

@corot
We will have to update the build farm.
regarding the -devel, I have followed the repo convention.

[corot]

Ok, I finally installed jazzy, so I can take over this
Iron is EOL this month, so I will skip

• I'll rename master as Humble
• Merge this and @renan028's PR on master (== jazzy)
  hopefully rolling and jazzy are compatible by now