Thread safety fixes for footprint #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2023 17:13
* Keep same smart pointer to object within a scope.
Have calculateMinAndMaxDistances return values instead.
Closed
7 tasks
added 2 commits
October 13, 2023 13:46
LeifHookedWireless
changed the title
SteveMacenski
requested changes
Oct 13, 2023
added 2 commits
October 14, 2023 16:30
SteveMacenski
requested changes
Oct 16, 2023
SteveMacenski
approved these changes
Nov 3, 2023
|
@LeifHookedWireless retriggering CI, but you had a failure with obstacle tests in costmap 2D. If the new CI job also fails, that means this has a regression that you should look at. But pending that, I approve this PR |
|
Yeah @LeifHookedWireless multiple tests are failing |
SteveMacenski
approved these changes
Nov 4, 2023
jwallace42
pushed a commit
to jwallace42/navigation2
that referenced
this pull request
Jan 3, 2024
* Don't assign bad values to radius, even temporarily. * Thread safety: * Keep same smart pointer to object within a scope. * Revert can_load_messages fixes. those will go in a different PR * There's no easy way to pass references back in a thread-safe way. Have calculateMinAndMaxDistances return values instead. * Revert unnecessary changes "Thread safety:" This reverts commit 98e2f8d. * Protect access to footprint via mutex. * Revert "Protect access to footprint via mutex." This reverts commit 405cc17. * Use atomic assignment for footprint. * Add comment about atomic load/store. * Initialize footprint. If accessed before assigned was returning a NULL reference. --------- Co-authored-by: Leif Terry <leif@peanutrobotics.com> Signed-off-by: gg <josho.wallace@gmail.com>
Rayman
added a commit
to nobleo/teb_local_planner
that referenced
this pull request
Apr 2, 2024
This PR fixes the change in API for `calculateMinAndMaxDistances` due to the following PR: ros-navigation/navigation2#3875
enricosutera
pushed a commit
to enricosutera/navigation2
that referenced
this pull request
May 19, 2024
* Don't assign bad values to radius, even temporarily. * Thread safety: * Keep same smart pointer to object within a scope. * Revert can_load_messages fixes. those will go in a different PR * There's no easy way to pass references back in a thread-safe way. Have calculateMinAndMaxDistances return values instead. * Revert unnecessary changes "Thread safety:" This reverts commit 98e2f8d. * Protect access to footprint via mutex. * Revert "Protect access to footprint via mutex." This reverts commit 405cc17. * Use atomic assignment for footprint. * Add comment about atomic load/store. * Initialize footprint. If accessed before assigned was returning a NULL reference. --------- Co-authored-by: Leif Terry <leif@peanutrobotics.com> Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
* Don't assign bad values to radius, even temporarily. * Thread safety: * Keep same smart pointer to object within a scope. * Revert can_load_messages fixes. those will go in a different PR * There's no easy way to pass references back in a thread-safe way. Have calculateMinAndMaxDistances return values instead. * Revert unnecessary changes "Thread safety:" This reverts commit 98e2f8d. * Protect access to footprint via mutex. * Revert "Protect access to footprint via mutex." This reverts commit 405cc17. * Use atomic assignment for footprint. * Add comment about atomic load/store. * Initialize footprint. If accessed before assigned was returning a NULL reference. --------- Co-authored-by: Leif Terry <leif@peanutrobotics.com>
corot
pushed a commit
to rst-tu-dortmund/teb_local_planner
that referenced
this pull request
Nov 8, 2024
This PR fixes the change in API for `calculateMinAndMaxDistances` due to the following PR: ros-navigation/navigation2#3875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: