Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA properties are sometimes rendered as "NA" in HTML #99

Closed
wch opened this issue Jun 12, 2018 · 1 comment · Fixed by #100
Closed

NA properties are sometimes rendered as "NA" in HTML #99

wch opened this issue Jun 12, 2018 · 1 comment · Fixed by #100

Comments

@wch
Copy link
Collaborator

wch commented Jun 12, 2018

If an argument to a tag function is NA, then it should be turned into an empty HTML attribute:

div(class = "abc", foo=NA)
#> <div class="abc" foo></div>

However, if there are two other arguments with the same name, then the NA will turn into "NA":

div(class = "abc", class = "xyz", foo=NA)
#> <div class="abc xyz" foo="NA"></div>
@jjallaire
Copy link
Member

Oh, sorry. Forget my comment (I see that the bug is to make sure that the behavior I am relying on always occurs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants