Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure NA attributes are rendered as blank. Fixes #99 #100

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

wch
Copy link
Collaborator

@wch wch commented Jun 12, 2018

This fixes #99.

Instead of this:

div(class = "abc", class = "xyz", foo=NA)
#> <div class="abc xyz" foo="NA"></div>

It now does this:

div(class = "abc", class = "xyz", foo=NA)
#> <div class="abc xyz" foo></div>

@wch wch requested a review from jcheng5 June 12, 2018 19:55
@jjallaire
Copy link
Member

I actually have a scenario right now where I depend on the NA behavior to add the async attribute to a <script> tag, e.g. <script async src = "...">. How can I do this after we merge this PR? How do we know that others aren't relying on this behavior?

@wch wch merged commit 3aee819 into rstudio:master Jun 15, 2018
@wch wch deleted the fix-na-attrib branch June 15, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NA properties are sometimes rendered as "NA" in HTML
3 participants