Add tagAddRenderHook() function
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Apr 15, 2021
cpsievert
reviewed
Apr 15, 2021
cpsievert
reviewed
Apr 15, 2021
wch
reviewed
Apr 16, 2021
wch
reviewed
Apr 16, 2021
* Use rlang to eval the `tagname` when making the function * document * Use new_function() approach Co-authored-by: Carson <cpsievert1@gmail.com>
cpsievert
reviewed
Apr 16, 2021
cpsievert
reviewed
Apr 16, 2021
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
cpsievert
approved these changes
Apr 16, 2021
cpsievert
reviewed
Apr 16, 2021
This was referenced Apr 19, 2021
|
The other |
wch
reviewed
Apr 20, 2021
wch
reviewed
Apr 20, 2021
* master: Rename `rlang::sexp_address()` to `rlang::obj_address()` (#220) Set min `rlang` version to 0.4.10.9000
…nc, add = TRUE)` to `tagAddRenderHooks(x, func, replace = FALSE)`
schloerke
changed the title
tagRenderHook() functiontagAddRenderHook() function
cpsievert
reviewed
Apr 20, 2021
cpsievert
reviewed
Apr 20, 2021
|
(The error above is a GHA false positive error due to a caching failure.) |
cpsievert
reviewed
Apr 21, 2021
cpsievert
reviewed
Apr 21, 2021
cpsievert
reviewed
Apr 21, 2021
|
LGTM pending minor nitpicks 👍 |
* master: Return invisibly when not creating a new tagQuery() object (#228)
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
…into tag_render_fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagFunction()s are black boxes and do not provide plausible tag structures. Typically withtagFunction()s, the tag structure is known and only a class value or html dependency is added.To provide a better default tag structure,
TAG$.renderHookswill contain a list of render functions. When converted to tags withas.tags(TAG), if a render hook exists,as.tags.shiny.tag(TAG)will remove a single render hook, call it, and callas.tags(TAG2). This recursion will continue until no more render hooks exist. (To be safe, the hook is removed fromTAGbefore callinghook(TAG).)Using
tagAddRenderHook()(mixed withtagQuery()) will be preferred over using generictagFunction()s.