Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagAddRenderHook() function #215

Merged
merged 24 commits into from
Apr 21, 2021
Merged

Add tagAddRenderHook() function #215

merged 24 commits into from
Apr 21, 2021

Commits on Apr 15, 2021

  1. First pass with tag $.render method

    @schloerke
    schloerke committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    86bda35 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Display the raw tagname in the tag functions (#214) 

    * Use rlang to eval the `tagname` when making the function

* document

* Use new_function() approach

Co-authored-by: Carson <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6098a8a View commit details
    Browse the repository at this point in the history

  2. code review

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f8aee4e View commit details
    Browse the repository at this point in the history

  3. bump version; require for rlang::sexp_address

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    4c0b5ac View commit details
    Browse the repository at this point in the history

  4. Update R/tags.R 

    Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    26a871d View commit details
    Browse the repository at this point in the history

  5. renderHook

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a2ae4a1 View commit details
    Browse the repository at this point in the history

  6. Documentation improvements

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    ac113f1 View commit details
    Browse the repository at this point in the history

  7. Forgot a @param

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    28ff35d View commit details
    Browse the repository at this point in the history

  8. Update news

    @cpsievert
    cpsievert committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    1764868 View commit details
    Browse the repository at this point in the history

  9. Update NEWS.md

    @cpsievert
    cpsievert authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    b090d87 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Merge branch 'master' into tag_render_fn 

    * master:
  Rename `rlang::sexp_address()` to `rlang::obj_address()` (#220)
  Set min `rlang` version to 0.4.10.9000
    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1c99ee0 View commit details
    Browse the repository at this point in the history

  2. Use list of hook functions, not closures; Rename `tagRenderHook(x, fu… 

    …nc, add = TRUE)` to `tagAddRenderHooks(x, func, replace = FALSE)`
    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    0bd343f View commit details
    Browse the repository at this point in the history

  3. Typo

    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f6126b5 View commit details
    Browse the repository at this point in the history

  4. Update _pkgdown.yml

    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    91dc7f6 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7f07314 View commit details
    Browse the repository at this point in the history

  6. fix docs

    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1075aac View commit details
    Browse the repository at this point in the history

  7. Update NEWS.md

    @schloerke
    schloerke committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    e7494d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. update docs

    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    57ea529 View commit details
    Browse the repository at this point in the history

  2. Rename .renderHooks -> .renderHook where appropriate

    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    abf61de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tag_render_fn 

    * master:
  Return invisibly when not creating a new tagQuery() object (#228)
    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    9f9ef63 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    59530db View commit details
    Browse the repository at this point in the history

  5. Merge branch 'tag_render_fn' of https://github.com/rstudio/htmltools … 

    …into tag_render_fn
    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    257820c View commit details
    Browse the repository at this point in the history

  6. document

    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    1a15573 View commit details
    Browse the repository at this point in the history

  7. Cleaner diffs

    @schloerke
    schloerke committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    81898da View commit details
    Browse the repository at this point in the history