fix issue with reporting caching of installed packages (#2041)

rstudio · Nov 21, 2024 · 3ab8c65 · 3ab8c65
1 parent 12f7d7b
commit 3ab8c65
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,9 @@
 
 # renv 1.1.0  (UNRELEASED)
 
+* Fixed an issue where `renv` erroneously reported that installed packages were
+  cached when the cache was not writable. (#2041).
+
 * `renv` now supports updating of currently-installed packages via `renv::install()`
   when configured to use `pak`. (#2037)
 

diff --git a/R/install.R b/R/install.R
@@ -432,8 +432,9 @@ renv_install_package <- function(record) {
 
   # link into cache
   if (renv_cache_config_enabled(project = project)) {
-    renv_cache_synchronize(record, linkable = linkable)
-    feedback <- paste0(feedback, " and cached")
+    cached <- renv_cache_synchronize(record, linkable = linkable)
+    if (cached)
+      feedback <- paste(feedback, "and cached")
   }
 
   verbose <- config$install.verbose()