Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading messages if cache is not writable #2041

Closed
gowerc opened this issue Nov 21, 2024 · 1 comment
Closed

Misleading messages if cache is not writable #2041

gowerc opened this issue Nov 21, 2024 · 1 comment

Comments

@gowerc
Copy link

gowerc commented Nov 21, 2024

We recently noticed that if the renv cache is readable but not writable renv fails to cache the package (understandable) however it still reports to the user that successfully cache the package which we found to be very confusing / misleading (took us a while to work out why our package wasn't be restored quickly) 😄

Steps to reproduce:

mkdir cachedir
chmod 555 cachedir
export RENV_PATHS_CACHE=$(pwd)/cachedir
Rscript --no-environ -e "renv::init()"
Rscript --no-environ -e "renv::install('htmlTable')"


- Installing rmarkdown ...                      OK [installed binary and cached in 4.9s]
- Installing htmlwidgets ...                    OK [installed binary and cached in 1.6s]
- Installing rstudioapi ...                     OK [installed binary and cached in 1.2s]
- Installing htmlTable ...                      OK [installed binary and cached in 2.3s]

Despite the message being printed if you then check the cachedir you'll see it is empty still.

@kevinushey
Copy link
Collaborator

Many thanks for the bug report and reproducible example! This should be fixed up with 3ab8c65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants