Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bslib::sidebar() tests #153

Merged
merged 12 commits into from
Jun 2, 2023
Merged

bslib::sidebar() tests #153

merged 12 commits into from
Jun 2, 2023

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Mar 3, 2023 •
edited
Loading

Covers the various ways a sidebar() can be rendered with layout_sidebar(), page_navbar(), and navs_tab_card()/navs_pill_card()

@cpsievert cpsievert mentioned this pull request Mar 6, 2023
Closed
5 tasks
@cpsievert cpsievert marked this pull request as ready for review March 6, 2023 22:36
@cpsievert cpsievert requested a review from schloerke March 6, 2023 22:37
@cpsievert cpsievert self-assigned this Mar 20, 2023
@schloerke schloerke marked this pull request as draft May 2, 2023 17:45
@schloerke
Copy link
Contributor

LGTM; Waiting mobile tests from #153 (comment)

@cpsievert cpsievert marked this pull request as ready for review May 8, 2023 22:36
@cpsievert cpsievert requested a review from gadenbuie May 8, 2023 23:00
@cpsievert
Copy link
Contributor Author

@gadenbuie these are the only other sidebar tests we have at the moment (besides #164)...lmk if you think there's important scenarios that we need coverage on...

gadenbuie
gadenbuie approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are good smoke tests and a good compliment to our other sidebar tests, each of which are more fine-grained. I don't see anything that we need to add to this test at this time

@cpsievert cpsievert merged commit da7b815 into main Jun 2, 2023
@cpsievert cpsievert deleted the sidebar-layout branch June 2, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

@schloerke schloerke Awaiting requested review from schloerke

Assignees

@cpsievert cpsievert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpsievert @schloerke @gadenbuie