310-311: Sidebar tests with dynamic UI, tabfocus order, sidebar_toggle()
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
May 8, 2023
cpsievert
reviewed
May 8, 2023
inst/apps/310-bslib-sidebar-dynamic/tests/testthat/test-shinytest2.R
Outdated
Show resolved
Hide resolved
schloerke
reviewed
May 8, 2023
Comment on lines
18
to
69
| key_press_factory <- function(app) { | ||
| brwsr <- app$get_chromote_session() | ||
|
|
||
| function(which = "Tab", shift = FALSE) { | ||
| virtual_code <- switch( | ||
| which, | ||
| Tab = 9, | ||
| Enter = 13, | ||
| Escape = 27, | ||
| ArrowLeft = 37, | ||
| ArrowUp = 38, | ||
| ArrowRight = 39, | ||
| ArrowDown = 40, | ||
| Backspace = 8, | ||
| Delete = 46, | ||
| Home = 36, | ||
| End = 35, | ||
| PageUp = 33, | ||
| PageDown = 34, | ||
| Space = 32 | ||
| ) | ||
|
|
||
| modifiers <- 0 | ||
| if (shift) modifiers <- modifiers + 8 | ||
| # if (command) modifiers <- modifiers + 4 | ||
| # if (control) modifiers <- modifiers + 2 | ||
| # if (alt) modifiers <- modifiers + 1 | ||
|
|
||
| events <- | ||
| brwsr$Input$dispatchKeyEvent( | ||
| "rawKeyDown", | ||
| windowsVirtualKeyCode = virtual_code, | ||
| code = which, | ||
| key = which, | ||
| modifiers = modifiers, | ||
| wait_ = FALSE | ||
| )$then( | ||
| brwsr$Input$dispatchKeyEvent( | ||
| "keyUp", | ||
| windowsVirtualKeyCode = virtual_code, | ||
| code = which, | ||
| key = which, | ||
| modifiers = modifiers, | ||
| wait_ = FALSE | ||
| ) | ||
| ) | ||
|
|
||
| brwsr$wait_for(events) | ||
|
|
||
| invisible(app) | ||
| } | ||
| } |
There was a problem hiding this comment.
Should something like this be added to shinytest2?
Related: rstudio/shinytest2#33
There was a problem hiding this comment.
Yes! I'd consider this a first rough draft for something that I'd love to see in shinytest2.
I found some helpful source data in the playwright repo: https://github.com/microsoft/playwright/blob/1f209204cd18bce7d1bfae50f5af105dec752df8/packages/playwright-core/src/server/usKeyboardLayout.ts
Two things that would be useful to take into account:
- For completeness it'd be helpful to be able to do keydown, keyup and key "press" events.
- AFAICT, the difference between
rawKeyDownandkeyDownis that withrawKeyDownno text is expected to be entered. Playwright takes that into account and in the user-facing api that's also described here
gadenbuie
changed the title
gadenbuie
changed the title
sidebar_toggle()
cpsievert
approved these changes
May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two test suites around the bslib sidebar implementation:
310-bslib-sidebar-dynamictests the sidebar when added to the page dynamically. The sidebar dependencies are not present on page load but are included when the sidebars are added viainsertUI(). We test general function and form of the sidebar, in particular around initialization state and the collapse toggle event handlers that would not work correctly if the sidebar dependencies did not include special post-page-load initialization methods.311-bslib-sidebar-toggle-methodstests the tab focus order of nested sidebars and all of the related sidebar toggling methods, including server-sidesidebar_toggle().