Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app_path() should work with trailing / #370

Merged
merged 3 commits into from
Dec 2, 2020
Merged

app_path() should work with trailing / #370

merged 3 commits into from
Dec 2, 2020

Conversation

schloerke
Copy link
Contributor

@schloerke schloerke commented Dec 2, 2020 •
edited
Loading

Offending line: bd9646a#diff-60bef5af43a1bd541299ce9bceeb226afb23deaa5e637b145c85e05ffd552b0cR128

Causing errors in shiny template tests.

?file.exists

(However, directory names must not include a trailing backslash or slash on Windows.)

@schloerke
Copy link
Contributor Author

schloerke commented Dec 2, 2020 •
edited
Loading

There are windows failures in 4f3ce0f. This shows that the test works.

There are no windows failures in ebbd13

(rstudio/webdriver#59 is randomly occurring in the tests.)

@schloerke schloerke marked this pull request as ready for review December 2, 2020 17:22
@schloerke schloerke requested a review from wch December 2, 2020 17:22
@wch wch merged commit ee85d82 into master Dec 2, 2020
@wch wch deleted the dirfile_exists branch December 2, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @wch