Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #59

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Update README.md #59

merged 3 commits into from
Jul 15, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Jul 15, 2020

What does this implement/fix?

パルスカウンタはI2Cの通信速度を下げなくても問題がない場合があるのでREADMEを変更します。

Does this close any currently open issues?

しません

How has this been tested?

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh requested a review from ShotaAk July 15, 2020 01:47
@Tiryoh Tiryoh marked this pull request as ready for review July 15, 2020 01:47
@Tiryoh Tiryoh added the Type: Documentation Documentation only changes label Jul 15, 2020
ShotaAk
ShotaAk reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。

Tiryoh and others added 2 commits July 15, 2020 11:04
@Tiryoh
Update README.md
7d5feab 
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
@Tiryoh
Update README.md
b29e216
@Tiryoh Tiryoh requested a review from ShotaAk July 15, 2020 02:06
ShotaAk
ShotaAk approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います

@ShotaAk ShotaAk merged commit 0118a84 into master Jul 15, 2020
@ShotaAk ShotaAk deleted the docs/update-pulse-counter-note branch July 15, 2020 02:24
@Tiryoh
Copy link
Contributor Author

Tiryoh commented Jul 15, 2020

related to #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShotaAk ShotaAk ShotaAk approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation only changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiryoh @ShotaAk