Dockerfile with nodejs18 for Ubuntu 20.04 #19
Conversation
|
I am not sure if we want to mandate the We can bypass this merge if we dont want to downgrade to node18 on all of our systems. |
I think it is ok to downgrade to 18 for all users now, node 18 is still in maintenance for a while and we do not depend on any features from 20 at the moment. Please checkout #22 for an alternative approach without node version manager. |
|
Yes I'd agree with keeping it at 18 and not complicating the dependencies. Long term support is good till April 2025 :) |
| @@ -45,20 +46,29 @@ RUN ollama serve & while ! curl http://localhost:11434; do sleep 1; done; ollama | |||
| # Setup the custom API and frontend | |||
| WORKDIR /workspace | |||
| COPY --chmod=644 gswikichat gswikichat | |||
| COPY --chmod=755 frontend frontend | |||
| COPY --chmod=755 static static | |||
There was a problem hiding this comment.
Did we decide to go back to calling the frontend "static", even for Vue3?
There was a problem hiding this comment.
That must have been a merge error. Sorry for that.
| RUN curl -sL https://deb.nodesource.com/setup_20.x | bash | ||
| RUN apt-get install -y nodejs && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN npm cache clean -f | ||
| RUN npm install -g n | ||
| RUN n 18.17.1 |
There was a problem hiding this comment.
I assume that this branch PR is no longer relevant because the integration branch is more direct and streamlined than this solution
|
Covered in #22 |
Solves Issue [Bug] Docker build creates yarn error with esbuild #16
The Dockerfile originally downloaded the most recent stable LTS version of nodejs.
This caused a yarn and npm errors in the
docker build.The updated Dockerfile downloads specifically version
nodejs 18.17.1via a modified Dockerfile installation process.Now the yarn install and yarn build commands do not produce errors, and the Vue3 UI displays and behaves as expected.
What is the current behavior? (You can also link to an open issue here)
The Dockerfile originally downloaded the most recent stable LTS version of nodejs.
This caused a yarn and npm errors in the
docker build. See Issue [Bug] Docker build creates yarn error with esbuild #16What is the new behavior (if this is a feature change)?
It downloads specifically version nodejs 18.17.1 via a modified Dockerfile installation process.
The yarn install and yarn build commands do not produce errors, and the Vue3 UI displays and behaves as expected.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. Not breaking change. Only a previous nodejs version.