Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile lock versions node18 #22

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Conversation

rti
Copy link
Owner

@rti rti commented Feb 1, 2024

Followup to #13 with NodeJS downgraded to 18

rti and others added 5 commits January 30, 2024 07:39
This change locks the versions of
 - ollama (by taking ollama from the upstream docker image)
 - python libraries (by installing them via requirements.txt)

This also reorders the Dockerfile for faster rebuilds when developing
fronend or backend.
It is better to include *__pycache__* in the .gitignore and .dockerignore files to avoid any cache files in the whole tree.
@rti rti mentioned this pull request Feb 1, 2024
4 tasks
@rti rti requested a review from exowanderer February 1, 2024 21:04
Copy link
Collaborator

@exowanderer exowanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this branch's updates are already included in the integration branch. Is this moot?

@rti
Copy link
Owner Author

rti commented Feb 4, 2024

I believe that this branch's updates are already included in the integration branch. Is this moot?

Yes, they are.

@rti rti merged commit a8448bb into main Feb 4, 2024
@rti rti deleted the dockerfile-lock-versions-node18 branch February 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants