feature/GH-130: Add action item life duration status #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
52dcda3 to
0b66833
Compare
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
cd368c1 to
24b3249
Compare
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
24b3249 to
c477478
Compare
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
35799a1 to
9868f77
Compare
nikolaiprivalov
changed the title
we138
suggested changes
Oct 22, 2019
app/javascript/components/ActionItem/ActionItemFooter/ActionItemFooter.css
Outdated
Show resolved
Hide resolved
app/javascript/components/ActionItem/TransitionButton/TransitionButton.css
Outdated
Show resolved
Hide resolved
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
8b24c24 to
baf2006
Compare
nikolaiprivalov
force-pushed
the
feature/GH-130-Add-action-item-life-duration-status
branch
from
baf2006 to
c4b3bb7
Compare
k0va1
reviewed
Oct 24, 2019
| @@ -25,18 +28,67 @@ class ActionItemFooter extends React.Component { | |||
| }); | |||
| } | |||
|
|
|||
| handleMoveClick = () => { | |||
| fetch(`/api/${window.location.pathname}/action_items/${this.props.id}/move`, { | |||
There was a problem hiding this comment.
хорошая практика - выносить запросы к api в отдельный метод в отдельном файле в папке компонента
например requests.js или что-то подобное, а внутри него него должна быть функция move(), которую уже можно будет вызвать отсюда
There was a problem hiding this comment.
хорошая практика - выносить запросы к api в отдельный метод в отдельном файле в папке компонента
например requests.js или что-то подобное, а внутри него него должна быть функция move(), которую уже можно будет вызвать отсюда
уже писал об этом, ребята решили сделать это отдельным PR)
There was a problem hiding this comment.
understood! спасибо за подробное разьяснение по расположению. там где-то 15 таких фетчей. я возьму следующим таском их все разобрать.
we138
suggested changes
Oct 24, 2019
Co-Authored-By: Vitaliy Pecherin <pecherin.dev@gmail.com>
we138
approved these changes
Oct 24, 2019
k0va1
approved these changes
Oct 24, 2019
nikolaiprivalov
deleted the
feature/GH-130-Add-action-item-life-duration-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.