Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a few pending cops #84

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Enable a few pending cops #84

merged 1 commit into from
Nov 21, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Nov 21, 2023

Follow: rubocop/rubocop-rspec#1744


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@pirj pirj merged commit 3a749b0 into main Nov 21, 2023
21 of 23 checks passed
@pirj pirj deleted the enable-few-cops branch November 21, 2023 12:05
@pirj
Copy link
Member

pirj commented Nov 21, 2023

Thank you!

ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Jan 4, 2024
We released rubocop-rspec v2.26.0, so we update and enable a few pending cops.
and follow: rubocop/rubocop-capybara#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants