Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a few pending cops #84

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Enable a few pending cops #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,18 @@ Layout/LineContinuationSpacing:
Enabled: true
Layout/LineEndStringConcatenationIndentation:
Enabled: true
Lint/AmbiguousOperatorPrecedence:
Enabled: true
Lint/NonAtomicFileOperation:
Enabled: true
Style/EmptyHeredoc:
Enabled: true
Style/RedundantHeredocDelimiterQuotes:
Enabled: true
Style/RedundantStringEscape:
Enabled: true
Style/ReturnNilInPredicateMethodDefinition:
Enabled: true

# Enable pending rubocop-rspec cops.

Expand Down Expand Up @@ -157,6 +163,8 @@ RSpec/PendingWithoutReason:
Enabled: true
RSpec/RedundantAround:
Enabled: true
RSpec/ReceiveMessages:
Enabled: true
RSpec/SkipBlockInsideExample:
Enabled: true
RSpec/SortMetadata:
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ gem 'rake'
gem 'rspec', '~> 3.11'
gem 'rubocop-performance', '~> 1.7'
gem 'rubocop-rake', '~> 0.6'
gem 'rubocop-rspec', '~> 2.20.0'
gem 'rubocop-rspec', '~> 2.25.0'
gem 'simplecov', '>= 0.19'
gem 'yard'

Expand Down
4 changes: 2 additions & 2 deletions lib/rubocop/cop/capybara/click_link_or_button_style.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def on_send(node)
private

def offense?(node)
style == :strict && !strict_method?(node) ||
style == :link_or_button && !link_or_button_method?(node)
(style == :strict && !strict_method?(node)) ||
(style == :link_or_button && !link_or_button_method?(node))
end

def offense_message(node)
Expand Down
Loading