Merge pull request #392 from fatkodima/reverse_each-more-safe-navigation

Fix a false negative for `Performance/ReverseEach` when safe navigation is between `reverse` and `each`
rubocop · Nov 26, 2023 · c5bc8f4 · c5bc8f4
2 parents eb714d9 + 761025b
commit c5bc8f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/changelog/fix_false_negative_for_reverse_each.md b/changelog/fix_false_negative_for_reverse_each.md
@@ -0,0 +1 @@
+* [#390](https://github.com/rubocop/rubocop-performance/issues/390): Fix a false negative for `Performance/ReverseEach` when safe navigation is between `reverse` and `each`. ([@fatkodima][])
diff --git a/lib/rubocop/cop/performance/reverse_each.rb b/lib/rubocop/cop/performance/reverse_each.rb
@@ -27,7 +27,7 @@ class ReverseEach < Base
         RESTRICT_ON_SEND = %i[each].freeze
 
         def_node_matcher :reverse_each?, <<~MATCHER
-          (send (call _ :reverse) :each)
+          (call (call _ :reverse) :each)
         MATCHER
 
         def on_send(node)

diff --git a/spec/rubocop/cop/performance/reverse_each_spec.rb b/spec/rubocop/cop/performance/reverse_each_spec.rb
@@ -15,6 +15,13 @@
     RUBY
   end
 
+  it 'registers an offense when each is called on reverse with safe navigation operator chain' do
+    expect_offense(<<~RUBY)
+      array&.reverse&.each { |e| puts e }
+             ^^^^^^^^^^^^^ Use `reverse_each` instead of `reverse.each`.
+    RUBY
+  end
+
   it 'registers an offense when each is called on reverse on a variable' do
     expect_offense(<<~RUBY)
       arr = [1, 2, 3]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#390](https://github.com/rubocop/rubocop-performance/issues/390): Fix a false negative for `Performance/ReverseEach` when safe navigation is between `reverse` and `each`. ([@fatkodima][])