Fix a false negative for Performance/ReverseEach when safe navigation is between reverse and each
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Nov 25, 2023
| @@ -27,7 +27,7 @@ class ReverseEach < Base | |||
| RESTRICT_ON_SEND = %i[each].freeze | |||
|
|
|||
| def_node_matcher :reverse_each?, <<~MATCHER | |||
| (send (call _ :reverse) :each) | |||
| ({send csend} (call _ :reverse) :each) | |||
There was a problem hiding this comment.
Suggested change
| ({send csend} (call _ :reverse) :each) | |
| (call (call _ :reverse) :each) |
|
CI has been failed. Can you rebase with the latest master branch? |
fatkodima
force-pushed
the
reverse_each-more-safe-navigation
branch
from
1f9237a
to
73b8334
Compare
|
Updated. |
koic
reviewed
Nov 26, 2023
| @@ -12,6 +12,8 @@ | |||
| expect_offense(<<~RUBY) | |||
| array&.reverse.each { |e| puts e } | |||
| ^^^^^^^^^^^^ Use `reverse_each` instead of `reverse.each`. | |||
| array&.reverse&.each { |e| puts e } | |||
| ^^^^^^^^^^^^^ Use `reverse_each` instead of `reverse.each`. | |||
There was a problem hiding this comment.
Please separate this, an independent test instead of mixing it in the existing it block.
There was a problem hiding this comment.
Hate inventing new names for tests 😅 Updated
…on is between `reverse` and `each`
fatkodima
force-pushed
the
reverse_each-more-safe-navigation
branch
from
73b8334
to
761025b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390.