Merge pull request #1389 from ydah/fix/1388

Fix a false positive for `RSpec/NoExpectationExample` with pending using `skip` or `pending` inside an example

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 * Fix an error for `RSpec/Capybara/SpecificFinders` with no parentheses. ([@ydah][])
+* Fix a false positive for `RSpec/NoExpectationExample` with pending using `skip` or `pending` inside an example. ([@ydah][])
 
 ## 2.13.1 (2022-09-12)
 

lib/rubocop/cop/rspec/no_expectation_example.rb

@@ -49,10 +49,18 @@ class NoExpectationExample < Base
           send_pattern('#Expectations.all')
         )
 
+        # @!method including_any_skip_example?(node)
+        # @param [RuboCop::AST::Node] node
+        # @return [Boolean]
+        def_node_search :including_any_skip_example?, <<~PATTERN
+          (send nil? {:pending :skip} ...)
+        PATTERN
+
         # @param [RuboCop::AST::BlockNode] node
         def on_block(node)
           return unless regular_or_focused_example?(node)
           return if including_any_expectation?(node)
+          return if including_any_skip_example?(node)
 
           add_offense(node)
         end

spec/rubocop/cop/rspec/no_expectation_example_spec.rb

@@ -115,6 +115,28 @@
     end
   end
 
+  context 'with no expectation pending example when using `pending` ' \
+          'inside an example' do
+    it 'registers no offenses' do
+      expect_no_offenses(<<~RUBY)
+        it "is implemented but waiting" do
+          pending "something else getting finished"
+        end
+      RUBY
+    end
+  end
+
+  context 'with no expectation skipped example when using `skip` ' \
+          'inside an example' do
+    it 'registers no offenses' do
+      expect_no_offenses(<<~RUBY)
+        it "is skipped" do
+          skip
+        end
+      RUBY
+    end
+  end
+
   context 'when Ruby 2.7', :ruby27 do
     context 'with no expectation example with it' do
       it 'registers an offense' do