Improve performance when user does not override default RSpec Pattern config #507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that RuboCop::Cop::RSpec::Cop#rspec_pattern is not so fast.
RSpec Pattern setting is not defined in most case, I think.
So change to cache building Regexp for default case.
Here is the stackprof result of running ./bin/rubocop at rubocop repositories on master
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).bundle exec rake
) is passing.If you have created a new cop:
config/default.yml
.