Memoize Cop#rspec_pattern #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are going to memoize anyway, we might as well revert the previous optimisation done in #507 ? |
Good question. I just went for the quickest fix tbh, I didn't delve into the code and I didn't actually even check the impact. The memoization is only per cop though, that code might still execute more than it could? |
Would you prefer that I take over the PR? I’d like to dig a bit more into how we can perform this calculation only once across all cops. |
|
With pleasure. I was running my tests with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently #2 in the memory allocated when running RuboCop... And #1 should disappear soon too 😅
See detailed list in whitequark/parser#721