"too many arguments for format string" warning

[andyw8]

It doesn't cause a problem, but when running with warnings enabled, the following is emitted:

/home/runner/work/.../vendor/bundle/ruby/3.3.0/gems/rubocop-1.63.5/lib/rubocop/cop/mixin/surrounding_space.rb:87: warning: too many arguments for format string

(I think it may be a clash between the format defined by RuboCop and format defined in Kernel?)

The same can be seen when running RuboCop's own tests with config.warnings = true.

[Earlopain]

There are quite a few of these. Some cops define multiple offense format strings with different "arity" and they just all get the same amount of arguments passed.

I looked at this in the past and some are trivial to fix, some require a bit more finesse.

[andyw8]

Ah, I see, thanks. Feel free to close if it's already been discussed previously.

[Earlopain]

I haven't talked about this with anyone. It's not a very common usecase since it's mostly a cli tool but I think it would be nice to have RuboCop warning-free anyways for those that use it in other ways.

You probably won't be able to raise on warnings since RuboCop inspects some rather strange-looking code (mostly regex stuff) but most looked fixable from what I remember.

[Earlopain]

I'm trying to some of these off:

• Supress warnings during parsing whitequark/parser#1013 (lets see how that goes)
• Avoid some warnings "too many arguments for format string" #12911

Remaining:

• erb_new_arguments Avoid a ruby warning in Lint/ErbNewArguments #12935
• space_inside_string_interpolation (the one this issue is about) Avoid a ruby warning in Layout/SpaceInsideStringInterpolation #12936
• Setting Encoding.default_external/Encoding.default_internal. These ones need to be ignored and are test only. Remove warnings during tests when overwriting encoding #12915

Wasn't quite as much as I thought it would be. The regex warnings made up the bulk of all the warnings in the test suite