Supress warnings during parsing #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User input can contain arbitrary regexes.
Something like `Parser::CurrentRuby.parse("/[\177\01\1778]/")` shows a warning:
> character class has duplicated range: /[\x7f\x01\x7f8]/
`Parser::CurrentRuby.parse("9.9999e999")`
> Float 9.9999e999 out of range
Earlopain
changed the title
|
@koic Does it look good for you? I'm not sure if these warnings are a part of some implicit contract that other libraries might rely on. If not I believe we should merge it. |
8 tasks
|
I've ignored these warnings in RuboCop itself so this is not strictly necessary. If you feel there is some risk associated here then feel free to close (though it would be nice not having to ignore these warnings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User input can contain arbitrary regexes.
Something like
Parser::CurrentRuby.parse("/[\177\01\1778]/")shows a warning:I'm interested in getting the warning count in the RuboCop test suite down and since it has a few regex cops there are quite a few warnings of that kind as well. They are unactionable, RuboCop instead emulates these warnings by inspecting the ast parsing the regexp with the
regexp_parsergem.Also noticed the same for floats:
Parser::CurrentRuby.parse("9.9999e999")