Call super in API.inherited
#2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`API.make_inheritable` was overriding `.inherited` hook on given instance itself. But it was not calling `super` which is required to bubble up inheritance chain. This commit removes `.make_inheritable` and calls `super` instead. Fixes PR with reproducible spec ruby-grape#2179.
yogeshjain999
force-pushed
the
fix/overriding-api-inherited
branch
from
3920f3a
to
1587f07
Compare
apotonick
reviewed
Jul 9, 2021
| @@ -68,15 +69,6 @@ def call(*args, &block) | |||
| instance_for_rack.call(*args, &block) | |||
| end | |||
|
|
|||
| # Allows an API to itself be inheritable: | |||
| def make_inheritable(api) | |||
There was a problem hiding this comment.
Why this change? Couldn't we just call super in #inherited and leave the rest as it is? 🍻
There was a problem hiding this comment.
Calling this method with super was creating warnings about method redefinations as override_all_methods! gets called twice.
I guess make_inheritable was defined in order to pass extra argument, instead of super.
|
Given that tests are passing I'm inclined to merge this. WDYT @apotonick (and thanks for jumping in to review!)? |
|
Now looking great! We need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API.make_inheritablewas overriding.inheritedhook on given instance itself. But it was not callingsuperwhich is required to bubble up the inheritance chain.This PR removes
.make_inheritableand callssuperinstead.Fixes PR with reproducible spec #2179.