Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super in API.inherited #2180

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Call super in API.inherited #2180

merged 1 commit into from
Jul 13, 2021

Commits on Jul 8, 2021

  1. Call super in API.inherited 

    `API.make_inheritable` was overriding `.inherited` hook on given
instance itself. But it was not calling `super` which is required to
bubble up inheritance chain.

This commit removes `.make_inheritable` and calls `super` instead.

Fixes PR with reproducible spec ruby-grape#2179.
    @yogeshjain999
    yogeshjain999 committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    1587f07 View commit details
    Browse the repository at this point in the history