Raise error if unknow status code is passed to #status #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dabrorius
commented
Mar 10, 2015
dabrorius
commented
- Raise error if given status code is not included Rack::HTTP_STATUS_CODES
- Raise error if given status is not a Fixnum or Symbol
- Raise error if given status code is not included Rack::HTTP_STATUS_CODES - Raise error if given status is not a Fixnum or Symbol
dabrorius
force-pushed
the
filter_invalid_response_codes
branch
from
7b3ad91
to
2225485
Compare
|
👍 |
dblock
added a commit
that referenced
this pull request
Mar 10, 2015
Raise error if unknow status code is passed to #status
|
Why the error is raised if given status code is "unknown" Fixnum? |
|
Yeah, I missed that part, @dabrorius you should be able to do status [any number]. Would you please care to undo that? Thanks for raising this @dm1try. |
|
Sure no problem, I'll start another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.