Allow all Fixnum statuses #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dm1try Double-check this for me please? Merge at will. |
|
@dabrorius I think we need an explicit test for being able to set a status to a value not in that Rack list. |
| @@ -118,11 +118,6 @@ def initialize | |||
| .to raise_error(ArgumentError, 'Status code :foo_bar is invalid.') | |||
| end | |||
|
|
|||
| it 'raises error if unknow status code is passed' do | |||
| expect { subject.status 210 } | |||
| .to raise_error(ArgumentError, 'Status code 210 is invalid.') | |||
There was a problem hiding this comment.
So this test should be here, but assert the opposite, .to_not raise_error ...
There was a problem hiding this comment.
Ok, I thought we will just pretend like that feature never existed :)
dabrorius
force-pushed
the
allow_all_fixnum_statuses
branch
from
42a9352
to
7beec80
Compare
| expect { subject.status 210 } | ||
| .to raise_error(ArgumentError, 'Status code 210 is invalid.') | ||
| it 'accepts unknown Fixnum status codes' do | ||
| expect { subject.status 210 }.to_not raise_error |
There was a problem hiding this comment.
Can I be annoying? I think we also need an integration level test that says an endpoint actually returns this status. Thanks.
There was a problem hiding this comment.
Sure, I'll see what I can do.
|
@dblock I added few integration specs. Let me know if that's what you had in mind. |
|
Good. Will merge on 📗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for #952
I didn't edit changelog because #952 change description still seems valid.