Add post_install_message about change of fallbacks #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced problem with our projects by the change of fallbacks behavior.
We wanted to know the breaking change.
I want any users who will update i18n to know the change to avoid troubles.
I don't mind the detail(content) of
post_install_message
.I borrowed an idea from the other popular gem haml.
https://github.com/haml/haml/blob/f699ca90cf5ce09f71035aebe8c3b6d67401ebfa/haml.gemspec#L37
Main issue:
#415
Changes in Rails 6:
rails/rails#34383
rails/rails#33574
Not all users are affected by the fallbacks issue. (Affected users are much less.)
So
post_install_message
could be too much because it will be displayed to all users.The better alternative may be displaying warning message.
lib/i18n/locale/fallbacks.rb
Rails introduced message but it doesn't help the majority of current Rails users who use Rails (< 6.0).
https://github.com/rails/rails/pull/33574/files