-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #25693 - Update fallback config for i18n 1.1 gem #6336
Conversation
Issues: #25693 |
If this finds approval, I'd open an update for i18n to 1.2.0 for RPMs. The alternative would be to pin it to 1.0.x. |
[test upgrade] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
RPM PR: theforeman/rails-packaging#150 I guess this change should also go into 1.20 then? |
for 1.20 i think it's better to pin for debians (i assume that rpms are on 1.0 anyways?) |
@mmoll no, we have split them per version: https://yum.theforeman.org/rails/ |
OK, then I think this should go into develop and the RPM PR merged, I'll take care of pinning i18n in older DEB builds then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmoll !
@mmoll did you pin this for 1.20 debians? we're planning to do 1.20.2 this week |
@tbrisker Could we pin this in the -stable branch itself ( |
@mmoll sure, works for me. rpm uses scl which has 1.0.1 for 1.20 anyways. |
done. |
No description provided.