Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not accept :daily as shift_age #46

Closed
doloopwhile opened this issue Jan 17, 2020 · 2 comments
Closed

Does not accept :daily as shift_age #46

doloopwhile opened this issue Jan 17, 2020 · 2 comments

Comments

@doloopwhile
Copy link

Logger.new fails if shift_age is a symbol.

Error:

irb(main):003:0> Logger.new('a.log', :daily)
ArgumentError (invalid :shift_age :daily, should be daily, weekly, monthly, or everytime)

Environment:

$ bundle list
Gems included by the bundle:
  * bundler (2.0.2)
  * logger (1.4.2)

Expected behavior (My suggestion for design change):

Logger.new('a.log', :daily) works as well as Logger.new('a.log', 'daily').

@skryukov
Copy link

@sonots seems like a developer-friendly addition. What are your thoughts on this?

bazay added a commit to bazay/logger that referenced this issue Apr 7, 2022
bazay added a commit to bazay/logger that referenced this issue Apr 7, 2022
bazay added a commit to bazay/logger that referenced this issue Apr 7, 2022
bazay added a commit to bazay/logger that referenced this issue Apr 7, 2022
hsbt pushed a commit that referenced this issue Jun 6, 2024
matzbot pushed a commit to ruby/ruby that referenced this issue Jun 6, 2024
@hsbt
Copy link
Member

hsbt commented Jun 6, 2024

Fixed at 83502c2

@hsbt hsbt closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants