Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for symbols in #shift_age #73

Closed
wants to merge 2 commits into from
Closed

Add support for symbols in #shift_age #73

wants to merge 2 commits into from

Conversation

bazay
Copy link
Contributor

@bazay bazay commented Apr 7, 2022

Resolves issue: #46

olleolleolle
olleolleolle reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition!

lib/logger/version.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
olleolleolle
olleolleolle reviewed Apr 7, 2022
View reviewed changes
test/logger/test_logperiod.rb

def assert_previous_period_end_word(time, previous_date, words)
assert_time_word(:previous_period_end, time, previous_date, words)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These supporting methods make the whole test very readable!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the idea! 😄

@olleolleolle
Copy link
Contributor

@bazay How about naming the PR Add support for symbols in #shift_age? (That includes the name of the method, spelled right.)

@bazay bazay changed the title Shift age symbol support Add support for symbols in #shift_age Apr 7, 2022
@hsbt
Copy link
Member

hsbt commented Jun 6, 2024

@bazay Sorry to late response. I picked 83502c2 on master branch.

Thank you.

@hsbt hsbt closed this Jun 6, 2024
@hsbt hsbt mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazay @olleolleolle @hsbt