-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for symbols in #shift_age #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool addition!
5bd6ab8
to
8ee6119
Compare
|
||
def assert_previous_period_end_word(time, previous_date, words) | ||
assert_time_word(:previous_period_end, time, previous_date, words) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These supporting methods make the whole test very readable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the idea! 😄
8ee6119
to
fe2c0b4
Compare
@bazay How about naming the PR |
Resolves issue: ruby#46
fe2c0b4
to
33c0003
Compare
Resolves issue: #46