-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut a new release #257
Comments
Any ETA on the next release? |
Hopefully soon. |
Having problems with #259 |
*bump* |
Because we've accepted a large number of PRs, I need to do a full code review before doing the next release, which will be a minor version bump. In addition, I'm not completely clear how we manage releasing this code independently of MRI, I need to investigate further. @mame is there some process? Can we just release updated gem? |
Bumping again is there's a month left before the next Ruby version is released. @ioquatix I believe that is the process as documented here: https://github.com/ruby/openssl/blob/51181247a238b1fb148dad15b6fd2fa1471fc06e/CONTRIBUTING.md#relation-with-ruby-source-tree |
I have kicked this process off internally a week ago but the wheels are slow... will post an update once I know more. Thanks for the link @bdewater |
I start to migrate this repository into ruby-core at ruby/ruby#2693 At least, We should resolve the test failure on ruby-core repository. |
What was released in 2.7.0? |
Judging by the release notes, nothing new as far as the openssl gem: https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/ |
@hsbt can you explain the status of the current release? |
There is no progress. So, Originally ruby/ruby#2693 is your work, not me. |
@hsbt thanks, I will sort it out. |
Okay, so most/all of the changes in the Ruby source code have been down streamed now. In order to get to a 2.2.0 release, we need to address all the outstanding issues here: https://github.com/ruby/openssl/milestone/1 If you have time to help with this, please jump into an issue. |
The current master branch was broken with the Windows platform. You should fix it before releasing 2.2.0. see https://github.com/ruby/ruby/runs/322277594#step:10:1431 |
Thanks I will check |
IIRC before the Ruby 2.7 release window was missed that list was a lot smaller. Is there a reason to push back the next release even further once the Windows build is fixed? To me it seems having a release as soon as possible and syncing with Ruby trunk would be preferable over more/continued drift. Plenty of valuable stuff ready to be released as well. |
This release has been lingering for quite a while. I don't know what the typical process is, but is there something I can do to help ship this? |
Ok. So if I understand you correctly, we just need to close the issues referenced in that milestone. Is there a way forward where we vet and ship the changes already committed to master in a point release? |
There is so much stuff that has not been released for so long, so it will require a bit of effort but yeah it’s very close. |
What is the process for preparing a release? |
Again, At least, we need to fix ruby/ruby#2693 with the master of ruby/openssl. |
A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file. It has a pending change and I don't want to include it in an incomplete state. The initial implementation in commit 46e4bdb was not really useful. The issue is described in #305. #309 extended it to take the corresponding private key together. However, the new implementation was incompatible on Windows and was reverted by #320 to the initial one. (The prerequisite to implement it in) an alternative way is #288, and it's still cooking. |
I still think it's worth putting out a point release to get the other changes out. I've got a client waiting on a change I committed last summer—it’s a blocker to the release of two open source libraries. |
We can push that to the 2.3 release. |
Let's revert the changes for now, as it cannot be included in the 2.2.0 release. My comment on ruby#257: > A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file. It > has a pending change and I don't want to include it in an incomplete > state. > > The initial implementation in commit 46e4bdb was not really > useful. The issue is described in ruby#305. ruby#309 extended it > to take the corresponding private key together. However, the new > implementation was incompatible on Windows and was reverted by ruby#320 to > the initial one. > > (The prerequisite to implement it in) an alternative way is ruby#288, and > it's still cooking. This effectively reverts the following commits: - dacd089 ("ssl: suppress test failure with SSLContext#add_certificate_chain_file", 2020-03-09) - 46e4bdb ("Add support for SSL_CTX_use_certificate_chain_file. Fixes ruby#254.", 2019-06-13)
v2.2.0 is now pushed to rubygems.org. |
@rhenium can we make 2.2.0 release soon?
The text was updated successfully, but these errors were encountered: