Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a new release #257

Closed
ioquatix opened this issue Jun 13, 2019 · 29 comments · Fixed by #367
Closed

Cut a new release #257

ioquatix opened this issue Jun 13, 2019 · 29 comments · Fixed by #367
Assignees
Milestone

Comments

@ioquatix
Copy link
Member

@rhenium can we make 2.2.0 release soon?

@jdhollis
Copy link
Contributor

Any ETA on the next release?

@ioquatix
Copy link
Member Author

Hopefully soon.

@nikitarub
Copy link

Having problems with #259
Waiting for release.
What's the next release date?

@jdhollis
Copy link
Contributor

*bump*

@ioquatix
Copy link
Member Author

Because we've accepted a large number of PRs, I need to do a full code review before doing the next release, which will be a minor version bump. In addition, I'm not completely clear how we manage releasing this code independently of MRI, I need to investigate further.

@mame is there some process? Can we just release updated gem?

@ioquatix ioquatix self-assigned this Oct 13, 2019
@ioquatix ioquatix added this to the v2.2.0 milestone Oct 13, 2019
@bdewater
Copy link
Contributor

Bumping again is there's a month left before the next Ruby version is released.

@ioquatix I believe that is the process as documented here: https://github.com/ruby/openssl/blob/51181247a238b1fb148dad15b6fd2fa1471fc06e/CONTRIBUTING.md#relation-with-ruby-source-tree

@ioquatix
Copy link
Member Author

I have kicked this process off internally a week ago but the wheels are slow... will post an update once I know more. Thanks for the link @bdewater

@ioquatix
Copy link
Member Author

@rhenium I am going to meet @hsbt this week at Asakusa.rb - it would be great to do a release that day. Do you have time to meet up?

@hsbt
Copy link
Member

hsbt commented Nov 27, 2019

I start to migrate this repository into ruby-core at ruby/ruby#2693

At least, We should resolve the test failure on ruby-core repository.

@davispuh
Copy link

When new release could happen? There's several PRs merged in master which haven't been released. And last v2.1.2 release is a year old.

attels

@ioquatix
Copy link
Member Author

What was released in 2.7.0?

@jdhollis
Copy link
Contributor

Judging by the release notes, nothing new as far as the openssl gem: https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

@ioquatix
Copy link
Member Author

@hsbt can you explain the status of the current release?

@hsbt
Copy link
Member

hsbt commented Dec 28, 2019

There is no progress.

So, Originally ruby/ruby#2693 is your work, not me.

@ioquatix
Copy link
Member Author

@hsbt thanks, I will sort it out.

@ioquatix
Copy link
Member Author

Okay, so most/all of the changes in the Ruby source code have been down streamed now.

In order to get to a 2.2.0 release, we need to address all the outstanding issues here: https://github.com/ruby/openssl/milestone/1

If you have time to help with this, please jump into an issue.

@hsbt
Copy link
Member

hsbt commented Dec 29, 2019

@ioquatix

The current master branch was broken with the Windows platform. You should fix it before releasing 2.2.0.

see https://github.com/ruby/ruby/runs/322277594#step:10:1431

@ioquatix
Copy link
Member Author

Thanks I will check

@bdewater
Copy link
Contributor

bdewater commented Dec 31, 2019

In order to get to a 2.2.0 release, we need to address all the outstanding issues here: https://github.com/ruby/openssl/milestone/1

IIRC before the Ruby 2.7 release window was missed that list was a lot smaller. Is there a reason to push back the next release even further once the Windows build is fixed? To me it seems having a release as soon as possible and syncing with Ruby trunk would be preferable over more/continued drift. Plenty of valuable stuff ready to be released as well.

@jdhollis
Copy link
Contributor

This release has been lingering for quite a while. I don't know what the typical process is, but is there something I can do to help ship this?

@ioquatix
Copy link
Member Author

@jdhollis
Copy link
Contributor

Ok. So if I understand you correctly, we just need to close the issues referenced in that milestone.

Is there a way forward where we vet and ship the changes already committed to master in a point release?

@ioquatix
Copy link
Member Author

There is so much stuff that has not been released for so long, so it will require a bit of effort but yeah it’s very close.

@jdhollis
Copy link
Contributor

What is the process for preparing a release?

@hsbt
Copy link
Member

hsbt commented Jan 28, 2020

Again, At least, we need to fix ruby/ruby#2693 with the master of ruby/openssl.

@rhenium
Copy link
Member

rhenium commented May 10, 2020

A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file. It has a pending change and I don't want to include it in an incomplete state.

The initial implementation in commit 46e4bdb was not really useful. The issue is described in #305. #309 extended it to take the corresponding private key together. However, the new implementation was incompatible on Windows and was reverted by #320 to the initial one.

(The prerequisite to implement it in) an alternative way is #288, and it's still cooking.

@jdhollis
Copy link
Contributor

jdhollis commented May 10, 2020

I still think it's worth putting out a point release to get the other changes out.

I've got a client waiting on a change I committed last summer—it’s a blocker to the release of two open source libraries.

@ioquatix
Copy link
Member Author

A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file

We can push that to the 2.3 release.

rhenium added a commit to rhenium/ruby-openssl that referenced this issue May 13, 2020
Let's revert the changes for now, as it cannot be included in the 2.2.0
release.

My comment on ruby#257:

> A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file. It
> has a pending change and I don't want to include it in an incomplete
> state.
>
> The initial implementation in commit 46e4bdb was not really
> useful. The issue is described in ruby#305. ruby#309 extended it
> to take the corresponding private key together. However, the new
> implementation was incompatible on Windows and was reverted by ruby#320 to
> the initial one.
>
> (The prerequisite to implement it in) an alternative way is ruby#288, and
> it's still cooking.

This effectively reverts the following commits:

 - dacd089 ("ssl: suppress test failure with SSLContext#add_certificate_chain_file", 2020-03-09)
 - 46e4bdb ("Add support for SSL_CTX_use_certificate_chain_file. Fixes ruby#254.", 2019-06-13)
@rhenium rhenium mentioned this issue May 13, 2020
3 tasks
@rhenium
Copy link
Member

rhenium commented May 13, 2020

v2.2.0 is now pushed to rubygems.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

7 participants