Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.2.0 #367

Merged
merged 5 commits into from
May 13, 2020
Merged

Release 2.2.0 #367

merged 5 commits into from
May 13, 2020

Conversation

rhenium
Copy link
Member

@rhenium rhenium commented May 13, 2020 •
edited
Loading

  • Make a tag and push to GitHub
  • Update gh-pages
  • gem build && gem push

Closes: #257

nobu and others added 5 commits May 13, 2020 14:55
@nobu @rhenium
Suppress -Wshorten-64-to-32 warnings
de02942 
[ Cherry-picked from ruby.git commit d8720eb7de9c. ]
@mame @rhenium
ext/openssl/ossl.h: Remove a variable that is used only in assert
306b26a 
It produces "unused variable" warnings in NDEBUG mode

[ Cherry-picked from ruby.git commit 3bca1b6aadff. ]
@rhenium
ssl: temporarily remove SSLContext#add_certificate_chain_file
ea92561 
Let's revert the changes for now, as it cannot be included in the 2.2.0
release.

My comment on ruby#257:

> A blocker is OpenSSL::SSL::SSLContext#add_certificate_chain_file. It
> has a pending change and I don't want to include it in an incomplete
> state.
>
> The initial implementation in commit 46e4bdb was not really
> useful. The issue is described in ruby#305. ruby#309 extended it
> to take the corresponding private key together. However, the new
> implementation was incompatible on Windows and was reverted by ruby#320 to
> the initial one.
>
> (The prerequisite to implement it in) an alternative way is ruby#288, and
> it's still cooking.

This effectively reverts the following commits:

 - dacd089 ("ssl: suppress test failure with SSLContext#add_certificate_chain_file", 2020-03-09)
 - 46e4bdb ("Add support for SSL_CTX_use_certificate_chain_file. Fixes ruby#254.", 2019-06-13)
@rhenium
.github/workflows: update OpenSSL and LibreSSL versions to test with
0a2e8c6
@rhenium
Ruby/OpenSSL 2.2.0
41587f6
@rhenium rhenium merged commit 41587f6 into ruby:master May 13, 2020
@ioquatix
Copy link
Member

Nice work - is it released now? Time to party?

@jdhollis
Copy link
Contributor

Certainly lovely news to wake up to this morning. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cut a new release
5 participants
@rhenium @ioquatix @jdhollis @nobu @mame