Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop to reference OpenSSL::VERSION on gemspec #321

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Feb 15, 2020

It failed to test with the ruby core repository.

@ioquatix
Copy link
Member

Why does it fail?

@hsbt
Copy link
Member Author

hsbt commented Feb 15, 2020

I don't know that. You should care to keep build status with this repository and ruby core repo.

@ioquatix
Copy link
Member

I don't know that. You should care to keep build status with this repository and ruby core repo.

Agreed.

Can you explain how I can pull it into ruby core repo in order to run tests? Is there documentation?

@hsbt
Copy link
Member Author

hsbt commented Feb 15, 2020

There is no complete guide for maintaining the default gems yet.

I always do the following instructions before releasing the new version.

  1. You pick the related commits from ruby/ruby repo into this repository.
  2. Run the https://github.com/ruby/ruby/blob/master/tool/sync_default_gems.rb#L5. After that, you copy files from the upstream of default gems.

3a. If you got the green status of test suite of ruby repo, You can commit it
3b-1. If you got the red status of test suite of ruby repo, You should fix it on ruby repo.
3b-2. You pick the 3b-1 fixes from ruby repo into the upstream of the default gems.

I will write the guide with this instructions to the documentation of ruby repo 😇

@ioquatix
Copy link
Member

Thanks, I am happy to do this before we release 2.2.0 so we can fix these issues properly. I won't be able to take a look until next week.

@deivid-rodriguez
Copy link

deivid-rodriguez commented Feb 15, 2020

Why does it fail?

I'm happy to investigate the reason for this.

I just found a maybe-similar issue with psych in ruby/psych#433. psych and openssl have in common that they are both default gems, and they are both required internally by rubygems. That's why I think the issues might be related.

I'll post here any findings.

@hsbt hsbt force-pushed the revert-ref-version-file branch from 28f07c1 to bc9b80d Compare February 15, 2020 22:35
@hsbt hsbt merged commit f49e711 into master Feb 16, 2020
@hsbt hsbt deleted the revert-ref-version-file branch February 16, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants