Remove unnecessary check on version #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
remove_unnecessary_check_on_version
branch
from
1ce33a0 to
6f8bbf8
Compare
|
Just for completeness, the warning can be reproduced by running |
Removing it triggers the following warnings when running `bundle` under jruby from the root of the `psych` repo prints the following warnings: ``` /path/to/jruby-9.2.9.0/lib/ruby/gems/shared/gems/psych-3.1.0-java/lib/psych/versions.rb:7: warning: already initialized constant VERSION /path/to//jruby-9.2.9.0/lib/ruby/gems/shared/gems/psych-3.1.0-java/lib/psych/versions.rb:10: warning: already initialized constant DEFAULT_SNAKEYAML_VERSION ``` This is because bundler loads the versions file relatively from the local gemspec, and then internally loads the psych gem, causing the redefinition warnings. Instead, we modify the $LOAD_PATH so that when working locally on the `psych` repo, the local version of `psych` gets used.
deivid-rodriguez
force-pushed
the
remove_unnecessary_check_on_version
branch
from
6f8bbf8 to
a3fc819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the warnings being fixed in #390 to try to come up with a better solution.
Initially, I was able to reproduce the issue by running
bundlefrom the root of this repo. The issue happened because my jruby installation had apsychinstallation at:~/.rbenv/versions/jruby-9.2.9.0/lib/ruby/gems/shared/gems, and that specific installation did not have the version guard inversions.rbthat this repository included. So, when runningbundlefirst the local gemspec would be loaded which loads the versions.rb file in the repository relatively, thenbundlerwould load the "system" version of psych without the version guard, causing the redefinition warnings.The changes in this PR fix the issue because the local version of
psychis always loaded.However, I cannot reproduce on a pristine installation of jruby, because
psychis not included in the~/.rbenv/versions/jruby-9.2.9.0/lib/ruby/gems/shared/gems, so now I'm not sure how to reproduce this anymore... :/