Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red-based darkfish color scheme #1191

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Red-based darkfish color scheme #1191

merged 5 commits into from
Oct 23, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 12, 2024

I want to use this change to address the top 2 feedback around RDoc (and docs.ruby-lang.org):

  1. Green is not the best highlight color for Ruby's documentation. Ideally it should be red
  2. The highlight color is overused in links. This means the highlight color doesn't highlight anything while visually overwhelming readers

Demo

Screenshot 2024-10-13 at 10 37 41
rdoc-new-color-scheme.mp4

@st0012 st0012 merged commit f69dc47 into master Oct 23, 2024
51 checks passed
@st0012 st0012 deleted the new-color-scheme-2 branch October 23, 2024 22:36
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 23, 2024
(ruby/rdoc#1191)

* Cleanup rdoc.css

* Use red as the highlight color

* Use the same red as ruby-lang.org

* Make main section links stand out more

* Remove scrollbar styling

ruby/rdoc@f69dc470ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants