multiline_repl do not need to depend on RubyLex #502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, it seems that test_yamatanooroti fails.
class TerminationChecker < RubyLexnow needs context in constructor andmultiline_repldoes not work now.I'm also opening a pull request in irb (ruby/irb#500) that deletes
RubyLex#process_nesting_levelandRubyLex#process_literal_typeand it will also breaks reline's test.I think multiline_repl don't need to depend on RubyLex.
I implement simple
TerminationChecker.terminated?andAutoIndent#calculate_indentthat only looksifdefend, brackets and parenthesis.I also find that
ruby -Ilib test/reline/yamatanooroti/multiline_repl --auto-indentwas not working, no indent was applied.