Skip to content

Conversation

@tompng
Copy link
Member

@tompng tompng commented Apr 12, 2023

Reline's test no longer depends on irb.

CI was failing in ruby 2.6 because github:ruby/irb requires ruby >= 2.7

Could not find compatible versions

Because every version of irb depends on Ruby >= 2.7
  and Gemfile depends on irb >= 0,
  Ruby >= 2.7 is required.
So, because current Ruby version is = 2.6.10,
  version solving has failed.

https://github.com/ruby/reline/actions/runs/4678386950/jobs/8287063665?pr=532

tompng added 2 commits April 12, 2023 21:52
Reline's test no longer depends on irb.
github:ruby/irb requires ruby >= 2.7 but reline's test is run in >= 2.6
@ima1zumi
Copy link
Member

Oh, are you removing IRB tests?
I think we aren't running it due to dependencies. I think we aimed to ensure IRB isn't broken by Reline changes, as it's the main user.

@ima1zumi
Copy link
Member

There was a PR that started to run IRB tests on CI.
#53

At that time, they were running IRB tests because it was difficult to test terminal emulators.
I think we could remove IRB tests now that we have yamatanooroti.

@tompng
Copy link
Member Author

tompng commented Apr 12, 2023

Reline is already not using irb in tests and the test matrix using irb had no effect. Test depending on irb was removed in #502

Before that, reline was requiring irb only to use RubyLex for calculating number of autoindent and code termination. I think it was not testing/ensuring integrity of irb and reline.

@tompng tompng merged commit 127a84d into ruby:master Apr 12, 2023
@tompng tompng deleted the remove_irb_from_test_dependeicy branch April 12, 2023 14:38
@st0012
Copy link
Member

st0012 commented Apr 12, 2023

Although it's not the intention, I feel it could still help capturing compatibility issues with IRB? Like if there's a PR that'd break IRB, it's probably already merged when we detect it on the IRB side, which means we'll need additional work to revert/patch the change.

I understand that ideally we should decouple reline's tests from IRB, but the reality is that IRB still is the biggest reline user, which provides the coverage we can use. Although debug also uses reline, it disable reline in tests.

How about we put this test in its own workflow and give it its own Ruby matrix that matches IRB's requirement?

@tompng
Copy link
Member Author

tompng commented Apr 12, 2023

I see and I agree. I will revert the workflow. 🙇

@tompng tompng mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants