Skip to content

Add Podcasts section to Community #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

olivierlacan
Copy link
Contributor

This is definitely a little self-serving since I just launched
http://rubyfacets.com/ today but I've listed the other existing Ruby podcasts
that I know are still publishing new episodes at the moment. For now that
includes Ruby Rogues and the Ruby on Rails Podcast but I'm sure others will
find more relevant podcasts in languages other than English.

@stomar
Copy link
Contributor

stomar commented Sep 25, 2016

I'm generally in favour of listing some podcasts, but I still have some objections with this PR:

  • I would rather wait some time before including a freshly launched podcast; but I'm ok with the other 2
  • please amend the commit message to include only the necessary information (including the en tag); duplicating the complete PR description, including information on personal motivation etc., is not necessary
  • please use named link references instead of numbers, see the Wiki

@colby-swandale
Copy link
Member

@olivierlacan are you able to address the feedback? If not i can look into getting this merged.

Includes Ruby Rogues and the Ruby on Rails Podcast since they're the
most prominent Ruby-related podcasts in English but I'm sure there might
be more in other languages.
@olivierlacan
Copy link
Contributor Author

@stomar @colby-swandale Only took 2 years but addressed all issues and removed reference to the (now defunct) Ruby Facets podcast.

@hsbt hsbt mentioned this pull request Mar 4, 2019
@stomar stomar self-assigned this Mar 7, 2019
@stomar stomar merged commit b26c5fe into ruby:master Mar 8, 2019
stomar added a commit that referenced this pull request Mar 8, 2019
Add Podcasts section to Community

Conflicts:
  en/community/index.md (outdated URLs)
@stomar
Copy link
Contributor

stomar commented Mar 8, 2019

Thank you and sorry for the delay! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants