Skip to content

Add podcasts section to community page (id) #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2019
Merged

Add podcasts section to community page (id) #2001

merged 4 commits into from
Dec 7, 2019

Conversation

meisyal
Copy link
Contributor

@meisyal meisyal commented Mar 12, 2019

As mentioned on PR #1466, changes:

  • Add podcasts section to community page
  • Add a new page for podcasts.

@meisyal meisyal requested a review from a team March 12, 2019 12:32
@stomar
Copy link
Contributor

stomar commented Mar 12, 2019

Maybe let‘s wait a bit for the follow up PR #1999.

@meisyal
Copy link
Contributor Author

meisyal commented Mar 13, 2019

Sure @stomar. If there is any changes on that PR, I will also update this translation.

@meisyal
Copy link
Contributor Author

meisyal commented Aug 20, 2019

Some commits added because there is changes on #1999.

By the way, #1999 has been merged @stomar.

@meisyal
Copy link
Contributor Author

meisyal commented Oct 8, 2019

Hi, there are some changes on this PR (commit b1acdd9 and 76b2d13).

Could you give a review again @gozali or @kuntoaji?

@meisyal
Copy link
Contributor Author

meisyal commented Dec 2, 2019

Hi @kuntoaji, do you still have a comment for this translation?

Thank you.

@kuntoaji
Copy link
Contributor

kuntoaji commented Dec 6, 2019

nope, LGTM..

@meisyal meisyal merged commit c6e381a into ruby:master Dec 7, 2019
@meisyal meisyal deleted the podcast-page branch December 7, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuntoaji kuntoaji kuntoaji approved these changes

Assignees
No one assigned
Labels
content translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meisyal @stomar @kuntoaji @jcserracampos