Skip to content

Translate Patch Writer's Guide (ko) #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Conversation

yous
Copy link
Member

@yous yous commented Jan 29, 2019

Ref: #1894

Actual diff is ef21837.

@ruby/www-ruby-lang-org-i18n-ko Review please. 🙏

@yous yous requested a review from a team January 29, 2019 09:09
Copy link
Member

@riseshia riseshia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except comments above

Copy link
Member

@riseshia riseshia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@yous yous merged commit c38799a into ruby:master Feb 1, 2019
@yous yous deleted the writing-patches-ko branch February 1, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants